Skip to content

feat: add GCP standard otel attributes for python client #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 19, 2025
Merged

feat: add GCP standard otel attributes for python client #1308

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e084b58
chore: add standard otel attributes for GCP python client lib
harshachinta Feb 18, 2025
7705d3f
chore: test fixes
harshachinta Feb 18, 2025
a327a70
chore: fix tests
harshachinta Feb 18, 2025
33bf317
chore: test fix
harshachinta Feb 18, 2025
1af7857
chore: test fixes
harshachinta Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions google/cloud/spanner_v1/_opentelemetry_tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ def trace_call(name, session=None, extra_attributes=None, observability_options=
"net.host.name": SpannerClient.DEFAULT_ENDPOINT,
OTEL_SCOPE_NAME: TRACER_NAME,
OTEL_SCOPE_VERSION: TRACER_VERSION,
# Standard GCP attributes for OTel, attributes are used for internal purpose and are subjected to change
"gcp.client.service": "spanner",
"gcp.client.version": TRACER_VERSION,
"gcp.client.repo": "googleapis/python-spanner",
}

if extra_attributes:
Expand Down
3 changes: 3 additions & 0 deletions tests/system/test_session_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,9 @@ def _make_attributes(db_instance, **kwargs):
"db.url": "spanner.googleapis.com",
"net.host.name": "spanner.googleapis.com",
"db.instance": db_instance,
"gcp.client.service": "spanner",
"gcp.client.version": ot_helpers.LIB_VERSION,
"gcp.client.repo": "googleapis/python-spanner",
}
ot_helpers.enrich_with_otel_scope(attributes)

Expand Down
Loading