-
Notifications
You must be signed in to change notification settings - Fork 101
feat(spanner): add samples for instance partitions #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
harshachinta
merged 8 commits into
googleapis:main
from
varuncnaik:spanner-create-instance-partition
Aug 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
47ffa78
feat(spanner): add samples for instance partitions
varuncnaik 4d26a21
Merge branch 'main' into spanner-create-instance-partition
harshachinta 7d3aac2
Merge branch 'main' into spanner-create-instance-partition
varuncnaik 488e55e
PR feedback
varuncnaik ea3ddda
Merge branch 'main' into spanner-create-instance-partition
harshachinta ba2aa77
Merge branch 'main' into spanner-create-instance-partition
harshachinta 5a4b819
Merge branch 'main' into spanner-create-instance-partition
harshachinta 1bc1144
Merge branch 'main' into spanner-create-instance-partition
harshachinta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we follow one of the 2 approaches,
python-spanner/samples/samples/snippets_test.py
Line 149 in ec96d36
This will prevent instance creation time when running tests and also reduce the no of instances that get created.
This test can be marked as dependent to the instance creation test like
python-spanner/samples/samples/snippets_test.py
Line 226 in ec96d36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented Approach 2. The challenge with reusing an existing instance is that there are several restrictions around instance partitions. Notably: