Skip to content

chore(spanner): unskip emulator tests for proto #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2024
Merged

chore(spanner): unskip emulator tests for proto #1145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
429e302
fix(spanner): unskip emulator tests for proto
harshachinta May 27, 2024
919dbdf
Merge branch 'main' into proto-emulator-tests
harshachinta Jul 11, 2024
5b23aab
Merge branch 'main' into proto-emulator-tests
harshachinta Jul 29, 2024
dcdc1c3
Merge branch 'main' into proto-emulator-tests
harshachinta Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/system/test_database_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,7 +897,6 @@ def _unit_of_work(transaction, test):


def test_create_table_with_proto_columns(
not_emulator,
not_postgres,
shared_instance,
databases_to_delete,
Expand Down
2 changes: 1 addition & 1 deletion tests/system/test_session_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2649,7 +2649,7 @@ def test_execute_sql_w_query_param_struct(sessions_database, not_postgres):


def test_execute_sql_w_proto_message_bindings(
not_emulator, not_postgres, sessions_database, database_dialect
not_postgres, sessions_database, database_dialect
):
singer_info = _sample_data.SINGER_INFO_1
singer_info_bytes = base64.b64encode(singer_info.SerializeToString())
Expand Down