Skip to content

Conversation

asthamohta
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Jul 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2021
@asthamohta asthamohta requested a review from vi3k6i5 July 21, 2021 11:01
Copy link
Contributor

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has 2 PRs mixed in it, Remove the benchmarking PR from it, as that is a separate PR.

@vi3k6i5 vi3k6i5 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 16, 2021
@vi3k6i5
Copy link
Contributor

vi3k6i5 commented Sep 21, 2021

Closing this as this + other changes were done in another PR #710

Thanks for all the effort put for this 👍

@vi3k6i5 vi3k6i5 closed this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants