Skip to content

Conversation

timgraham
Copy link
Contributor

fixes #321

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2020
Copy link
Contributor

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Tim!

@odeke-em
Copy link
Contributor

odeke-em commented Apr 3, 2020

@timgraham please rebase from master! #406 got merged in and now tests can run on Google Cloud Source.

@timgraham timgraham force-pushed the 321-decimalfield-error branch from 264ea45 to 60c9a55 Compare April 3, 2020 18:55
@odeke-em odeke-em added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 3, 2020
@odeke-em odeke-em added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 3, 2020
@odeke-em odeke-em merged commit f27a4d1 into googleapis:master Apr 7, 2020
@timgraham timgraham deleted the 321-decimalfield-error branch April 7, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

all: discourage use of DecimalField until Spanner has NUMERIC

4 participants