Skip to content

feat: Add support for google.cloud.ndb.__version__ #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parthea merged 1 commit into from
Nov 24, 2023
Merged

feat: Add support for google.cloud.ndb.__version__ #929

parthea merged 1 commit into from
Nov 24, 2023

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Nov 22, 2023

This PR migrates from using a hardcoded version in setup.py to a version module to make it easy to query the current version of google-cloud-ndb

(py39) partheniou@partheniou-vm-3:~/git/python-ndb$ python3
Python 3.9.16 (main, Mar  2 2023, 17:52:22) 
[GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import google.cloud.ndb
>>> google.cloud.ndb.__version__
'2.2.2'

@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Nov 22, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2023
@parthea parthea marked this pull request as ready for review November 24, 2023 19:09
@parthea parthea requested review from a team as code owners November 24, 2023 19:09
@parthea parthea marked this pull request as draft November 24, 2023 19:15
@parthea parthea force-pushed the add-version-module branch 2 times, most recently from 1535c86 to e2a03d8 Compare November 24, 2023 19:20
@parthea parthea changed the title feat: add support for google.cloud.ndb.__version__ feat: Add support for google.cloud.ndb.__version__ Nov 24, 2023
@parthea parthea marked this pull request as ready for review November 24, 2023 20:07
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2023
@parthea
Copy link
Contributor Author

parthea commented Nov 24, 2023

@rwhogg Please could you review?

rwhogg
rwhogg reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@rwhogg rwhogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@parthea parthea merged commit 42b3f01 into main Nov 24, 2023
@parthea parthea deleted the add-version-module branch November 24, 2023 20:28
@release-please release-please bot mentioned this pull request Nov 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwhogg rwhogg rwhogg approved these changes

Assignees

@rwhogg rwhogg

Labels

api: datastore Issues related to the googleapis/python-ndb API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea @rwhogg