chore: Added mypy to noxfile #932
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
owlbot.py
Outdated
|
|
||
| place_before( | ||
| "noxfile.py", | ||
| """ |
There was a problem hiding this comment.
I see firestore adds an escape character here. Maybe that's why it's not working?
There was a problem hiding this comment.
I found out that using s.replace instead of place_before makes it work. The escape characters were used because s.replace takes in a regex.
| """Verify type hints are mypy compatible.""" | ||
| session.install("-e", ".") | ||
| session.install("mypy", "types-setuptools") | ||
| # TODO: also verify types on tests and logging_v2, big undertakings |
There was a problem hiding this comment.
are those big undertakings? logging_v2 should already have valid types in place. And I'd say tests are optional
There was a problem hiding this comment.
I guess big is an overexaggeration, but when I ran mypy there were 22 errors in 12 files.
|
you should also add a github action to execute mypy as a presubmit check |
product-auto-label
bot
added
the
stale: old
product-auto-label
bot
added
stale: extraold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕