Skip to content

Conversation

@slowy07
Copy link

@slowy07 slowy07 commented Aug 1, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #409 🦕

@slowy07 slowy07 requested a review from a team August 1, 2021 13:44
@slowy07 slowy07 requested a review from a team as a code owner August 1, 2021 13:44
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Aug 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2021
@slowy07 slowy07 changed the title fix: lambda function should not in, indentation, and lint issue minor fixing Aug 1, 2021
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! Unfortunately, both these files are generated code, and would need fixing up in their source template, rather than in this repository.

The whitespace and lambda fixes should be trivial to do there: the cst.Element one, however, is apparently gnarly: @software-dov has a comment there referring the the "log chipper" formatting which happens.

@busunkim96, @parthea could we perhaps run black over the scripts/ directory via owlbot.py to make these fixes in place?

@tseaver tseaver closed this Aug 1, 2021
@slowy07 slowy07 deleted the minor-fixing branch August 1, 2021 19:04
@slowy07
Copy link
Author

slowy07 commented Aug 1, 2021

Thanks for the patch! Unfortunately, both these files are generated code, and would need fixing up in their source template, rather than in this repository.

The whitespace and lambda fixes should be trivial to do there: the cst.Element one, however, is apparently gnarly: @software-dov has a comment there referring the the "log chipper" formatting which happens.

@busunkim96, @parthea could we perhaps run black over the scripts/ directory via owlbot.py to make these fixes in place?

okay,sorry for changes sir @tseaver

@parthea
Copy link
Contributor

parthea commented Aug 2, 2021

This was fixed in googleapis/gapic-generator-python#963 . We should see these changes in the next gapic generator update.

@slowy07
Copy link
Author

slowy07 commented Aug 2, 2021

This was fixed in googleapis/gapic-generator-python#963 . We should see these changes in the next gapic generator update.

okay thanks @parthea !, and sorry for the change make mess up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

indentation issue and lambda function should 'not in'

3 participants