Skip to content
This repository has been archived by the owner on Jul 6, 2023. It is now read-only.

chore: migrate to main branch #55

Merged
merged 9 commits into from
Aug 25, 2021
Merged

chore: migrate to main branch #55

merged 9 commits into from
Aug 25, 2021

Conversation

dandhlee
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #54 🦕

@dandhlee dandhlee requested a review from parthea August 24, 2021 02:39
@dandhlee dandhlee requested a review from a team as a code owner August 24, 2021 02:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2021
@product-auto-label product-auto-label bot added the api: domains Issues related to the googleapis/python-domains API. label Aug 24, 2021
parthea
parthea reviewed Aug 24, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One observation, otherwise LGTM.

README.rst Outdated
@@ -9,7 +9,7 @@ Python Client for Cloud Domains
- `Product Documentation`_

.. |beta| image:: https://img.shields.io/badge/support-beta-orange.svg
:target: https://github.com/googleapis/google-cloud-python/blob/master/README.rst#beta-support
:target: https://github.com/googleapis/google-cloud-python/blob/main/README.rst#beta-support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get 404 with the new link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dandhlee dandhlee changed the title docs: migrate to main branch chore: migrate to main branch Aug 24, 2021
@dandhlee dandhlee requested a review from parthea August 24, 2021 21:47
@dandhlee
Copy link
Contributor Author

Please take a look again!

@parthea parthea merged commit d7a74a3 into main Aug 25, 2021
@parthea parthea deleted the to_main branch August 25, 2021 16:59
@parthea parthea mentioned this pull request Aug 27, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
api: domains Issues related to the googleapis/python-domains API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to main branch
2 participants
@dandhlee @parthea