Skip to content
This repository has been archived by the owner on Dec 17, 2023. It is now read-only.

chore: migrate to main branch #372

Merged
merged 9 commits into from
Aug 25, 2021
Merged

chore: migrate to main branch #372

merged 9 commits into from
Aug 25, 2021

Conversation

dandhlee
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #371 🦕

@dandhlee dandhlee requested a review from parthea August 24, 2021 01:55
@dandhlee dandhlee requested a review from a team as a code owner August 24, 2021 01:55
@product-auto-label product-auto-label bot added the api: dialogflow Issues related to the googleapis/python-dialogflow API. label Aug 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2021
@dandhlee dandhlee added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 24, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 24, 2021
@dandhlee
Copy link
Contributor Author

@parthea OwlBot seems to be failing on this PR, could you help take a look? Not sure what's triggering it to fail :/

@parthea
Copy link
Contributor

parthea commented Aug 24, 2021

@dandhlee Unrelated to your changes, there is a syntax error in owlbot.py here in the main branch.

Instead of

templated_files = common.py_library(
python.py_samples(skip_readmes=True)
    samples=False,  # set to True only if there are samples
    microgenerator=True,
    cov_level=98,

)

s.move(templated_files, excludes=[".coveragerc"])  # microgenerator has a good .coveragerc file

It should be

templated_files = common.py_library(
    samples=False,  # set to True only if there are samples
    microgenerator=True,
    cov_level=98,
)

s.move(templated_files, excludes=[".coveragerc"])  # microgenerator has a good .coveragerc file

python.py_samples(skip_readmes=True)

@dandhlee dandhlee requested a review from a team as a code owner August 24, 2021 22:44
@dandhlee dandhlee changed the title docs: migrate to main branch chore: migrate to main branch Aug 24, 2021
@dandhlee
Copy link
Contributor Author

Fixed it. Please take a look again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: dialogflow Issues related to the googleapis/python-dialogflow API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to main branch
2 participants