Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

chore: migrate to main branch #138

Merged
merged 7 commits into from
Aug 25, 2021
Merged

chore: migrate to main branch #138

merged 7 commits into from
Aug 25, 2021

Conversation

dandhlee
Copy link
Contributor

@dandhlee dandhlee commented Aug 24, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #137 🦕

@dandhlee dandhlee requested a review from parthea August 24, 2021 01:17
@dandhlee dandhlee requested a review from a team as a code owner August 24, 2021 01:17
@product-auto-label product-auto-label bot added the api: datalabeling Issues related to the googleapis/python-datalabeling API. label Aug 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2021
@dandhlee dandhlee added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 24, 2021
@dandhlee dandhlee requested review from sgreenberg and a team as code owners August 24, 2021 01:21
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 24, 2021
@dandhlee dandhlee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor observations, otherwise LGTM.

UPGRADING.md Outdated
@@ -66,7 +66,7 @@ In `google-cloud-datalabeling<1.0.0`, parameters required by the API were positi

In the 1.0.0 release, all methods have a single positional parameter `request`. Method docstrings indicate whether a parameter is required or optional.

Some methods have additional keyword only parameters. The available parameters depend on the [`google.api.method_signature` annotation](https://github.com/googleapis/googleapis/blob/master/google/cloud/datalabeling/v1beta1/data_labeling_service.proto#L48) specified by the API producer.
Some methods have additional keyword only parameters. The available parameters depend on the [`google.api.method_signature` annotation](https://github.com/googleapis/googleapis/blob/main/google/cloud/datalabeling/v1beta1/data_labeling_service.proto#L48) specified by the API producer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get 404 with the new link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.rst Outdated
@@ -85,4 +85,4 @@ Next Steps
APIs that we cover.

.. _Data Labeling API Product documentation: https://cloud.google.com/data-labeling/docs
.. _repository’s main README: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/README.rst
.. _repository’s main README: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/main/README.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get 404 with the new link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

See https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get 404 with the new link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dandhlee dandhlee changed the title docs: migrate to main branch chore: migrate to main branch Aug 24, 2021
@dandhlee
Copy link
Contributor Author

Please take a look again!

@dandhlee dandhlee requested a review from parthea August 24, 2021 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: datalabeling Issues related to the googleapis/python-datalabeling API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to main branch
3 participants