feat: add basic interceptor to client #1206
Conversation
product-auto-label
bot
added
the
api: bigtable
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chalmerlowe
left a comment
chalmerlowe
left a comment
There was a problem hiding this comment.
I am approving, pending:
- See the #QUESTIONs and determine whether any changes need to be made, if no, then carry on.
- See the #PREFERENCEs and #NITs and see if there is merit to including them. If no, then carry on.
| row_key = b"bulk_mutate" | ||
| new_value = uuid.uuid4().hex.encode() | ||
| row_key, mutation = self._create_row_and_mutation( | ||
| (row_key, mutation) = self._create_row_and_mutation( |
There was a problem hiding this comment.
#PREFERENCE
Why are we encapsulating all of these values in parens? To the best of my knowledge, this is not required by either PEP 8 or the Google Python Style Guide nor have I heard it referred to as a best practice. I don't see any other examples of this practice anywhere else in this codebase.
Feels unnecessary. I recommend ditching them unless we have a really good reason to add them.
| (row_key, mutation) = self._create_row_and_mutation( | |
| row_key, mutation = self._create_row_and_mutation( |
There was a problem hiding this comment.
This code auto-generated, so this wasn't a conscious choice. Something must have changed in how black is post processing the generated code.
It feels unnecessary to me too, but it doesn't bother me enough to fight with the generation system to change it back
5 participants
This PR adds a new grpc interceptor to the client, to be used for metrics collection. Currently, the interceptor is a no-op. Interception logic will be added in a future change.