Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add pyarrow.large_string to the _ARROW_SCALAR_IDS_TO_BQ map #1796

Merged
merged 3 commits into from
Jan 24, 2024
Merged

fix: add pyarrow.large_string to the _ARROW_SCALAR_IDS_TO_BQ map #1796

merged 3 commits into from
Jan 24, 2024

Conversation

chelsea-lin
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1795🦕

@chelsea-lin chelsea-lin requested review from a team as code owners January 23, 2024 20:14
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 23, 2024
@chelsea-lin chelsea-lin mentioned this pull request Jan 23, 2024
Open
tswast
tswast approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast changed the title fix: add pyarrow.large_strign to the _ARROW_SCALAR_IDS_TO_BQ map fix: add pyarrow.large_string to the _ARROW_SCALAR_IDS_TO_BQ map Jan 24, 2024
@chelsea-lin chelsea-lin merged commit b402a6d into main Jan 24, 2024
22 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin branch January 24, 2024 20:41
@release-please release-please bot mentioned this pull request Jan 24, 2024
Merged
This was referenced Jan 30, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@kiraksi kiraksi Awaiting requested review from kiraksi kiraksi is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The _ARROW_SCALAR_IDS_TO_BQ mapping misses LargeStringArray type
2 participants
@chelsea-lin @tswast