This repository was archived by the owner on Nov 12, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
feat: introduce compatibility with native namespace packages #706
Merged
Linchin
merged 10 commits into
googleapis:main
from
kiraksi:native-namespace-compatibility
Dec 1, 2023
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5872585
feat: introduce compatibility with native namespace packages
kiraksi a85ddca
reformatted with black
kiraksi 92fd70b
removed pkg_resources
kiraksi 63e32cb
Moved importlib to extras and resolved issues with using it in tests
kiraksi d0ea035
reformatted with black
kiraksi 9413cae
Fixed mistake of not checking only first 3 indexes of PANDAS_VERSION
kiraksi f7587d9
Fixed another error in comparison strings
kiraksi b409420
Merge branch 'main' into native-namespace-compatibility
kiraksi 2864263
Merge branch 'main' into native-namespace-compatibility
kiraksi a112ec2
use setuptools.find_namespace_packages()
parthea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Copyright 2022 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import os | ||
| import subprocess | ||
| import sys | ||
|
|
||
|
|
||
| def test_namespace_package_compat(tmp_path): | ||
| # The ``google`` namespace package should not be masked | ||
| # by the presence of ``google-cloud-bigquery-storage``. | ||
| google = tmp_path / "google" | ||
| google.mkdir() | ||
| google.joinpath("othermod.py").write_text("") | ||
| env = dict(os.environ, PYTHONPATH=str(tmp_path)) | ||
| cmd = [sys.executable, "-m", "google.othermod"] | ||
| subprocess.check_call(cmd, env=env, shell=True) | ||
|
|
||
| # The ``google.cloud`` namespace package should not be masked | ||
| # by the presence of ``google-cloud-bigquery-storage``. | ||
| google_cloud = tmp_path / "google" / "cloud" | ||
| google_cloud.mkdir() | ||
| google_cloud.joinpath("othermod.py").write_text("") | ||
| env = dict(os.environ, PYTHONPATH=str(tmp_path)) | ||
| cmd = [sys.executable, "-m", "google.cloud.othermod"] | ||
| subprocess.check_call(cmd, env=env, shell=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.