-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove libcst as a required dependency #389
Conversation
libcst is only used for a one-off "fixup" script. It’s not necessary to always depend on it. It caused an issue on one project as old libcst versions don't ship macOS M1 wheels, and it took time to figure this out. (Also the instructions for using the fixup script were incorrect.)
Thanks for the fix! I agree that this dependency is not necessary in most cases. |
Would you be able to replicate this to other google python packages? In just the one google project I work on I see many other google packages depend on |
I only maintain the BigQuery-related packages, but I'll bring this up with our core Python team. |
Btw, although this has been fixed almost a year ago, there is no version of this (>=2.12) on conda-forge still. Not sure whether you officially support conda packages, but at the moment only pypi seems to work. |
libcst is only used for a one-off "fixup" script. It’s not necessary to always depend on it.
It caused an issue on one project as old libcst versions don't ship macOS M1 wheels, and it took time to figure this out.
(Also the instructions for using the fixup script were incorrect.)
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #395 🦕