-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate default branch from master to main #301
chore: migrate default branch from master to main #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget about docs/conf.py
:)
That's not a reference to a branch. I assumed, incorrectly, I couldn't change that, but I can! So I will! and owlbot.py too! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few references to the master
branch in release-procedure.md
and sqlite_master
in fauxdbi.py
(presumably that's just an arbitrary database name in used in a test query?).
The rest are more or less URLs to repos that didn't the migration to main
(yet?).
Yeah, I relied to much on the script. Fixed.
No, that's the name of a system table and can't be changed.
There were 2 google links that haven't changed yet. There was an SQLAlchemy link that I removed. It didn't add much, si I removed it. I think I'm done. :) |
@jimfulton Where are the changes to |
…/python-bigquery-sqlalchemy into migrate-default-branch-to-main
Sorry, forgot to push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question about a deleted link, the rest looks good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: