Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate default branch from master to main #301

Merged
merged 8 commits into from
Aug 27, 2021

Conversation

jimfulton
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Aug 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2021
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget about docs/conf.py :)

@jimfulton
Copy link
Contributor Author

Don't forget about docs/conf.py :)

That's not a reference to a branch. I assumed, incorrectly, I couldn't change that, but I can! So I will! and owlbot.py too! :)

docs/conf.py Outdated Show resolved Hide resolved
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few references to the master branch in release-procedure.md and sqlite_master in fauxdbi.py (presumably that's just an arbitrary database name in used in a test query?).

The rest are more or less URLs to repos that didn't the migration to main (yet?).

@jimfulton jimfulton marked this pull request as ready for review August 27, 2021 13:11
@jimfulton jimfulton requested a review from a team as a code owner August 27, 2021 13:11
@jimfulton
Copy link
Contributor Author

I found a few references to the master branch in release-procedure.md

Yeah, I relied to much on the script. Fixed.

and sqlite_master in fauxdbi.py (presumably that's just an arbitrary database name in used in a test query?).

No, that's the name of a system table and can't be changed.

The rest are more or less URLs to repos that didn't the migration to main (yet?).

There were 2 google links that haven't changed yet. There was an SQLAlchemy link that I removed. It didn't add much, si I removed it.

I think I'm done. :)

@plamut
Copy link

plamut commented Aug 27, 2021

@jimfulton Where are the changes to release-procedure.md, it appears there's a commit missing?

…/python-bigquery-sqlalchemy into migrate-default-branch-to-main
@jimfulton
Copy link
Contributor Author

@jimfulton Where are the changes to release-procedure.md, it appears there's a commit missing?

Sorry, forgot to push.

Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about a deleted link, the rest looks good now.

owlbot.py Show resolved Hide resolved
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimfulton jimfulton merged commit 0fad7b0 into googleapis:main Aug 27, 2021
@jimfulton jimfulton deleted the migrate-default-branch-to-main branch August 27, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants