-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: in-operator literal binds not handled properly #285
fix: in-operator literal binds not handled properly #285
Conversation
…com:jimfulton/python-bigquery-sqlalchemy into literal_binds_kwarg_with_an_IN_operator_252
and added unit test to cover it. Also fixed constraints
Reviewers: This PR boils down to this line: Normally, IN SQLAlchemy, when you pass values from Python, the values are passes as parameters. We override a methid, OTOH, for "literal" binds, values get knit into the SQL and aren't passes as parameters to the DB API. In this case, we can just call the base method and be done. |
To work around spurious test failures
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #252 🦕