Ab nested #829
Ab nested #829
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
bot
added
size: xl
| @@ -62,3 +62,6 @@ system_tests/local_test_setup | |||
| # Make sure a generated file isn't accidentally committed. | |||
| pylintrc | |||
| pylintrc.test | |||
| Dockerfile | |||
| bigframes/operations/python-bigquery-dataframes.code-workspace | |||
There was a problem hiding this comment.
I imagine we can ignore all *.code-workspace files/directories.
| @@ -62,3 +62,6 @@ system_tests/local_test_setup | |||
| # Make sure a generated file isn't accidentally committed. | |||
| pylintrc | |||
| pylintrc.test | |||
| Dockerfile | |||
| bigframes/operations/python-bigquery-dataframes.code-workspace | |||
| pyproject.toml_ | |||
There was a problem hiding this comment.
We could consider migrating to pyproject.toml in this project. I'm curious what problems it solved for you?
bigframes/core/__init__.py
Outdated
|
|
||
| import google.cloud.bigquery | ||
| import pandas | ||
| import pyarrow as pa | ||
| import pyarrow.feather as pa_feather | ||
|
|
||
| # schema lineage | ||
| from networkx import DiGraph |
There was a problem hiding this comment.
Nit: Except for the typing module and collections.abc, import modules not classes/functions.
| from networkx import DiGraph | |
| import networkx |
See: https://google.github.io/styleguide/pyguide.html#22-imports
Aside: Note to self: check that:
- networkx and its dependencies have a compatible license
- setup.py has networkx as a dependency and
- the constraints file(s) have a pin for networkx.
bigframes/core/__init__.py
Outdated
| import warnings | ||
| from collections.abc import Iterator | ||
| from collections import deque |
There was a problem hiding this comment.
Nit: Except for the typing module and collections.abc, import modules not classes/functions.
| from collections import deque | |
| import collections |
See: https://google.github.io/styleguide/pyguide.html#22-imports
Aside: when I run "owlbot", it will rearrange these imports alphabetically.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕