Skip to content

chore: Extract snapshot tests to different nox session #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Extract snapshot tests to different nox session #2274

wants to merge 2 commits into from

Conversation

@TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented Nov 17, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 17, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Nov 17, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review November 17, 2025 22:46
@TrevorBergeron TrevorBergeron requested review from a team as code owners November 17, 2025 22:46
chelsea-lin
chelsea-lin requested changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep the snapshot tests as part of the presubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chelsea-lin chelsea-lin chelsea-lin requested changes

@tswast tswast tswast approved these changes

@jialuoo jialuoo Awaiting requested review from jialuoo jialuoo is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Requested changes must be addressed to merge this pull request.

Assignees

@shobsi shobsi

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TrevorBergeron @tswast @chelsea-lin @shobsi