-
Notifications
You must be signed in to change notification settings - Fork 63
refactor: Migrate DataFrame display to use IPython's _repr_mimebundle_() protocol for anywidget mode #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shuoweil
wants to merge
19
commits into
main
Choose a base branch
from
shuowei-anywidget-html-repr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: Migrate DataFrame display to use IPython's _repr_mimebundle_() protocol for anywidget mode #2271
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0dc287e
feat: Refactor anywidget display to use _ipython_display_
shuoweil 94c05d7
Revert accidental changes to README.rst
shuoweil 1b15ef0
add testcase
shuoweil 53953bb
ipython_display_ to set fallback mimetypes
shuoweil 5397a59
remove _repr_html_()
shuoweil 689fa74
Revert "remove _repr_html_()"
shuoweil 6b407d4
change the fallback function name to better reflect the change
shuoweil 3cd960e
code refactor
shuoweil b0f1525
fix mypy
shuoweil 7e47895
Revert unncessary change
shuoweil 736929a
use test/plain for print(df)
shuoweil eb61fc0
fix failed testcase
shuoweil 3079a3c
reuse available data and optimize error handling
shuoweil 86e0b6a
update the testcase due to my optimization reduce the query calls number
shuoweil d53eea3
code refactor
shuoweil 8b9a2cf
function polish
shuoweil 1042a9e
Merge branch 'main' into shuowei-anywidget-html-repr
shuoweil 83513b5
Merge branch 'main' into shuowei-anywidget-html-repr
shuoweil 05a9245
notebook change
shuoweil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we define
selftwice?copy()is a pretty cheap operation (just makes a new block referencing the same expression), so I think we can just define it once.