Skip to content

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Nov 10, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 10, 2025
@tswast tswast marked this pull request as ready for review November 19, 2025 19:57
@tswast tswast requested review from a team as code owners November 19, 2025 19:57
@tswast tswast requested a review from sycai November 19, 2025 19:57
@tswast
Copy link
Collaborator Author

tswast commented Nov 19, 2025

e2e failures:

FAILED tests/system/small/test_dataframe_io.py::test_to_gbq_if_exists_is_replace
FAILED tests/system/small/test_dataframe_io.py::test_to_gbq_if_exists_is_append
FAILED tests/system/small/test_dataframe.py::test_to_gbq_table_labels - googl...
3 failed, 3502 passed, 33 skipped, 42 xfailed, 3 xpassed, 523 warnings in 751.92s (0:12:31)
nox > Command py.test --quiet -n=20 --timeout=600 --junitxml=small_prerelease_3.13_sponge_log.xml --cov=bigframes --cov=tests/system/small --cov-append --cov-config=.coveragerc --cov-report=term-missing --cov-fail-under=0 tests/system/small --ignore=tests/system/small/functions/test_remote_function.py failed with exit code 1
nox > Session system_prerelease failed.

I believe these are the known issue of SQLGlot incompatibility.

@sycai
Copy link
Contributor

sycai commented Nov 20, 2025

Thanks for the cleaning!

@tswast tswast merged commit f7fd2d2 into main Nov 20, 2025
24 checks passed
@tswast tswast deleted the b401261155-autosummary branch November 20, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants