refactor: make sqlglot compile_sql a top-level function #2244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
chelsea-lin
force-pushed
the
main_chelsealin_enablesqlglot
branch
3 times, most recently
from
bb989f5 to
68eb777
Compare
chelsea-lin
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
chelsea-lin
force-pushed
the
main_chelsealin_enablesqlglot
branch
from
cb181d3 to
ee59f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prepares to enable SQLGlot as the default compiler. Making compile_sql a top-level function makes it consistent with the existing Ibis API, which simplifies onboarding.