Skip to content

feat: Polars engine supports std, var #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

feat: Polars engine supports std, var #2215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bigframes/core/compile/polars/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,9 +535,11 @@ def compile_agg_op(
if isinstance(op, agg_ops.StdOp):
return pl.std(inputs[0])
if isinstance(op, agg_ops.VarOp):
return pl.var(inputs[0])
# polars var doesnt' support decimal, so use std instead
return pl.std(inputs[0]).pow(2)
if isinstance(op, agg_ops.PopVarOp):
return pl.var(inputs[0], ddof=0)
# polars var doesnt' support decimal, so use std instead
return pl.std(inputs[0], ddof=0).pow(2)
if isinstance(op, agg_ops.FirstNonNullOp):
return pl.col(*inputs).drop_nulls().first()
if isinstance(op, agg_ops.LastNonNullOp):
Expand Down
3 changes: 3 additions & 0 deletions bigframes/session/polars_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@
agg_ops.SumOp,
agg_ops.MeanOp,
agg_ops.CountOp,
agg_ops.VarOp,
agg_ops.PopVarOp,
agg_ops.StdOp,
)


Expand Down
14 changes: 14 additions & 0 deletions tests/system/small/engines/test_aggregation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,20 @@ def test_engines_unary_aggregates(
assert_equivalence_execution(node, REFERENCE_ENGINE, engine)


@pytest.mark.parametrize("engine", ["polars", "bq"], indirect=True)
@pytest.mark.parametrize(
"op",
[agg_ops.std_op, agg_ops.var_op, agg_ops.PopVarOp()],
)
def test_engines_unary_variance_aggregates(
scalars_array_value: array_value.ArrayValue,
engine,
op,
):
node = apply_agg_to_all_valid(scalars_array_value, op).node
assert_equivalence_execution(node, REFERENCE_ENGINE, engine)


def test_sql_engines_median_op_aggregates(
scalars_array_value: array_value.ArrayValue,
bigquery_client: bigquery.Client,
Expand Down