Skip to content

test: add polars sorting test #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: add polars sorting test #2207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion tests/system/small/engines/test_sorting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def test_engines_double_reverse(
"timestamp_col",
],
)
def test_engines_sort_over_column(
def test_engines_sort_over_column_descending_nulls_first(
scalars_array_value: array_value.ArrayValue, engine, sort_col
):
node = apply_reverse(scalars_array_value.node)
Expand All @@ -70,6 +70,33 @@ def test_engines_sort_over_column(
assert_equivalence_execution(node, REFERENCE_ENGINE, engine)


@pytest.mark.parametrize("engine", ["polars", "bq", "bq-sqlglot"], indirect=True)
@pytest.mark.parametrize(
"sort_col",
[
"bool_col",
"int64_col",
"bytes_col",
"date_col",
"datetime_col",
"int64_col",
"int64_too",
"numeric_col",
"float64_col",
"string_col",
"time_col",
"timestamp_col",
],
)
def test_engines_sort_over_column_descending_nulls_last(
scalars_array_value: array_value.ArrayValue, engine, sort_col
):
node = apply_reverse(scalars_array_value.node)
ORDER_EXPRESSIONS = (ordering.descending_over(sort_col, nulls_last=True),)
node = nodes.OrderByNode(node, ORDER_EXPRESSIONS)
assert_equivalence_execution(node, REFERENCE_ENGINE, engine)


@pytest.mark.parametrize("engine", ["polars", "bq", "bq-sqlglot"], indirect=True)
def test_engines_sort_multi_column_refs(
scalars_array_value: array_value.ArrayValue,
Expand Down