feat: support array output in remote_function
#1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is feature request to support use cases like creating custom feature vectors, embeddings etc.
product-auto-label
bot
added
the
api: bigquery
product-auto-label
bot
added
size: l
…tr array outputs
shobsi
requested review from
TrevorBergeron
and removed request for
GarrettWu
gcf-owl-bot
bot
removed
the
owlbot:run
Comment on lines
+1376
to
+1381
| output_type (type, default None): | ||
| Python type equivalent to the BigQuery return type. This is used | ||
| to coerce the return value of the BigQuery function to BigFrames | ||
| type. For example, if the BigQuery function returns a JSON | ||
| serialized array of integers such as "[1, 2, 3]", then user can | ||
| set `output_type=list[int]` to read it as array of integers [1, 2, 3]. |
There was a problem hiding this comment.
I don't know if this makes sense for existing bq functions. Its more helpful for local python functions where the output type is otherwise ambiguous. Users should call astype or similar methods to explicitly coerce the result.
There was a problem hiding this comment.
The place where it would be useful is reading back a remote function that was created using bigframes. When the user used it after creating, their code didn't have to call astype, so we want to give them a way to have that code continue to work after reading back. The test test_df_apply_axis_1_array_output captures this usecase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
remote_function: screen/5rMtCZVaUYKdqxPread_gbq_function: screen/6gzaxsHsjAMf79FSeries.apply: screen/9HkKMuWxMvbbPgfDataFrame.apply: screen/BoXH9A7d4hGpETuFixes internal issue 298876217 🦕