chore: add row_limit for text generators #1054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
Is this to server a customer feedback or to support our test infra? |
chelsea-lin
approved these changes
Oct 4, 2024
bigframes/ml/llm.py
Outdated
| @@ -598,6 +598,8 @@ class TextEmbeddingGenerator(base.BaseEstimator): | |||
| connection_name (str or None): | |||
| Connection to connect with remote service. str of the format <PROJECT_NUMBER/PROJECT_ID>.<LOCATION>.<CONNECTION_ID>. | |||
| If None, use default connection in session context. | |||
| row_limit (int or None): | |||
There was a problem hiding this comment.
nit: max_cols, which is used in other pandas methods.
bigframes/ml/llm.py
Outdated
| @@ -598,6 +598,8 @@ class TextEmbeddingGenerator(base.BaseEstimator): | |||
| connection_name (str or None): | |||
| Connection to connect with remote service. str of the format <PROJECT_NUMBER/PROJECT_ID>.<LOCATION>.<CONNECTION_ID>. | |||
| If None, use default connection in session context. | |||
| row_limit (int or None): | |||
| The maximum number of rows that this model can process. | |||
There was a problem hiding this comment.
nit: The maximum number of rows that this model can process per call. The model can be called multiple times.
Comment on lines
+601
to
+602
| max_rows (int or None): | ||
| The maximum number of rows that this model can process per call. |
There was a problem hiding this comment.
My feeling is this is better as a bigframes-wide setting. Alternatively, if we are just focusing on sem-join cardinality explosion, we can apply a narrow limit just for that case
chelsea-lin
added
the
do not merge
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps prevent unexpected large amount of data being processed by LLM