feat: Added MetricsTracerFactory for metrics collection and tracing #775
+817
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switched to draft as there might be some additional changes needed on implementation. However code is still largely review-ready |
parthea
added
the
needs more info
|
Hi @lszinv, Thanks for opening a pull request! Regrettably, this PR can't be reviewed/merged yet as there is some history with the open telemetry project that we need to follow up on. I'm checking with @rahul2393, and our broader SDK teams, to capture the requirements from stakeholders before moving forward with this PR. (Googlers see b/335736237 and b/331665246). |
parthea
added
the
status: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces enhancements to the metrics tracing functionaliy. It includes the implementation of a MetricsTracerFactory that facilitates the creation of MetricsTracer instances, allowing for more structured and efficient metrics collection and tracing.
The primary motivation for these changes is to enhance the Spanner client, while also ensuring that the modifications are generalized for broader implementation across other clients.
These changes are based on similar changes made for Java and Go.