Skip to content

chore: Revert "chore: move retry async check to wrap time" #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

parthea
Copy link
Collaborator

@parthea parthea commented Oct 22, 2024

Reverts #668

PR #668 causes tests to fail in the python-bigquery repository. See build log here from PR googleapis/python-bigquery#2045.

E               AssertionError: Calls not found.
E               Expected: [call(method='POST', path='/projects/test-project-123/jobs', data={'jobReference': {'jobId': 'job-id', 'projectId': 'test-project-123'}}, timeout=None),
E                call(method='POST', path='/projects/test-project-123/jobs', data={'jobReference': {'jobId': 'job-id', 'projectId': 'test-project-123'}}, timeout=None),
E                call(method='GET', path='/projects/test-project-123/jobs/job-id', query_params={'projection': 'full', 'location': 'US'}, timeout=128)]
E                 Actual: [call.__code__.co_flags.__and__(128),
E                call.__code__.co_flags.__and__().__bool__(),
E                call(method='POST', path='/projects/test-project-123/jobs', data={'jobReference': {'jobId': 'job-id', 'projectId': 'test-project-123'}}, timeout=None),
E                call(method='POST', path='/projects/test-project-123/jobs', data={'jobReference': {'jobId': 'job-id', 'projectId': 'test-project-123'}}, timeout=None),
E                call.__code__.co_flags.__and__(128),
E                call.__code__.co_flags.__and__().__bool__(),
E                call(method='GET', path='/projects/test-project-123/jobs/job-id', query_params={'projection': 'full', 'location': 'US'}, timeout=128)]

@parthea parthea requested review from a team as code owners October 22, 2024 17:22
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 22, 2024
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks!

@parthea parthea merged commit 7727405 into main Oct 22, 2024
43 checks passed
@parthea parthea deleted the revert-668-move_async_warning branch October 22, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants