chore: upgrade GAPIC Metadata from v1beta1 to v1 and add experiment logging integration test #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t logging integration test
product-auto-label
bot
added
the
api: aiplatform
google-cla
bot
added
the
cla: yes
sasha-gitg
changed the title
nachocano
reviewed
Oct 19, 2021
|
|
||
| def test_experiment_logging(self, shared_state): | ||
|
|
||
| experiment_name = self._make_display_name("experiment")[:56] |
There was a problem hiding this comment.
what is 56? can you add a comment, same below
There was a problem hiding this comment.
I truncated the name because the service was throwing on resource id validation:
E google.api_core.exceptions.InvalidArgument: 400 User-specified resource ID must match the regular expression '[a-z0-9][a-z0-9-]{0,127}'
Interestingly, that exception was only thrown when creating the run(execution) below but not the experiment(context).
I'll add a comment.
nachocano
reviewed
Oct 19, 2021
| @@ -113,6 +122,8 @@ | |||
| types.job_state = types.job_state_v1 | |||
| types.machine_resources = types.machine_resources_v1 | |||
| types.manual_batch_tuning_parameters = types.manual_batch_tuning_parameters_v1 | |||
| types.metadata_service = types.metadata_service_v1 | |||
| types.metadata_store = types.metadata_store_v1 | |||
There was a problem hiding this comment.
do we need to add metadata_schema as well, or not because we don't use it?
There was a problem hiding this comment.
It's currently being unused. We'll add it once it's used.
|
LGTM |
|
LGTM |
|
LGTM |
nachocano
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #740
b/203427575
b/201659393