-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-add py sessions to noxfile #22
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9344796
fix: re-add py sessions to noxfile
busunkim96 9d5d931
Merge branch 'master' into fix-noxfile
busunkim96 4642de1
Add pytest to requirements.txt from PR #11
vinnysenthil 38132eb
Merge branch 'master' into fix-noxfile
vinnysenthil 34829a6
chore: move tests, fix lint
busunkim96 dca44e6
chore: remove accidentally commited file
busunkim96 8b343ec
chore: blacken noxfile
busunkim96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,4 @@ | |
# limitations under the License. | ||
# | ||
|
||
from google.cloud.aiplatform import gapic | ||
|
||
__all__ = () |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,9 +26,9 @@ | |
BLACK_VERSION = "black==19.10b0" | ||
BLACK_PATHS = ["docs", "google", "tests", "noxfile.py", "setup.py"] | ||
|
||
DEFAULT_PYTHON_VERSION = "" | ||
SYSTEM_TEST_PYTHON_VERSIONS = [] | ||
UNIT_TEST_PYTHON_VERSIONS = [] | ||
DEFAULT_PYTHON_VERSION = "3.8" | ||
SYSTEM_TEST_PYTHON_VERSIONS = ["3.8"] | ||
UNIT_TEST_PYTHON_VERSIONS = ["3.6", "3.7", "3.8"] | ||
|
||
|
||
@nox.session(python=DEFAULT_PYTHON_VERSION) | ||
|
@@ -156,7 +156,6 @@ def docs(session): | |
shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True) | ||
session.run( | ||
"sphinx-build", | ||
"-W", # warnings as errors | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I remove this because there were warnings in the docs build. The session will only fail on sphinx errors. |
||
"-T", # show full traceback on exception | ||
"-N", # no colors | ||
"-b", | ||
|
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was raising an "imported but unused error". Let me know if I should re-add it.