feat: add filter and timestamp splits for custom training #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
sirtorry
requested review from
sasha-gitg,
morgandu,
ivanmkc,
vinnysenthil and
dizcology
sasha-gitg
requested changes
Feb 5, 2021
| @@ -217,6 +251,13 @@ def _create_input_data_config( | |||
| test_fraction=test_fraction_split, | |||
| ) | |||
|
|
|||
| # Create filter split spec | |||
| filter_split = gca_training_pipeline.FilterSplit( | |||
There was a problem hiding this comment.
What's the expected behavior of the service if both FractionSplit and FilterSplit are passed in?
It seems to me that only one should be passed in. Under that assumption it seems like we shouldn't default to creating FractionSplit and FilterSplit as that will automatically cause this service call to fail. Or does the service maintain a precedence ordering for Splits?
product-auto-label
bot
added
the
api: aiplatform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/172365904 and b/172368070 respectively.