Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updates so tests can run in different environments #1403

Merged
merged 2 commits into from
Jun 1, 2022
Merged

chore: updates so tests can run in different environments #1403

merged 2 commits into from
Jun 1, 2022

Conversation

sararob
Copy link
Contributor

@sararob sararob commented May 31, 2022

Updated two tests:

  • Added google_auth_mock to test_explain_saved_model* so those tests can run when GOOGLE_APPLICATION_CREDENTIALS is not set
  • Added skipif to test_training_jobs to skip tests when sys.executable is not set

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 31, 2022
@sararob sararob requested a review from sasha-gitg May 31, 2022 21:45
@product-auto-label product-auto-label bot added the api: vertex-ai Issues related to the googleapis/python-aiplatform API. label May 31, 2022
@sararob sararob merged commit 15fe100 into googleapis:main Jun 1, 2022
rosiezou pushed a commit that referenced this pull request Jun 16, 2022
@sararob @rosiezou
chore: updates so tests can run in different environments (#1403)
c8f6f35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sararob @sasha-gitg