-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dataplane code snippets for feature store service #713
Conversation
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
* Add resource creation and deletion including featurestore, entity type and feature.
4fce072
to
a94f08b
Compare
02bbd39
to
80e8c4d
Compare
samples/snippets/feature_store_service/batch_create_features_sample.py
Outdated
Show resolved
Hide resolved
samples/snippets/feature_store_service/batch_read_feature_values_sample.py
Show resolved
Hide resolved
samples/snippets/feature_store_service/batch_read_feature_values_sample.py
Outdated
Show resolved
Hide resolved
samples/snippets/feature_store_service/batch_create_features_sample.py
Outdated
Show resolved
Hide resolved
254e0a8
to
9dd3a7a
Compare
Re guidance for parameters list: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Import dependencies
- Instantiate the client library
- Handle authentication
- Prepare an API request
- Exercise the API
- Process the result
- Use correct region tags
- Region tags updated in cloud.google.com
- Self-contained, copy-paste-runnable
- Descriptive top-level comment
- Code comments in the body of the code snippet
- Lines of code (and 120 char lines)
- Levels of indirection
- Cyclomatic complexity
- Variable instantiation
- Variable types
- Adhere to language idioms
- Handle errors
- Test coverage
- Portable in multiple environments
samples/snippets/feature_store_service/batch_read_feature_values_sample.py
Show resolved
Hide resolved
samples/snippets/feature_store_service/batch_read_feature_values_sample.py
Outdated
Show resolved
Hide resolved
samples/snippets/feature_store_service/read_feature_values_sample_test.py
Show resolved
Hide resolved
samples/snippets/feature_store_service/read_feature_values_sample_test.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates make this LGTM.
You may want to verify that your region tags are consistent with those in the documentation, I haven't checked those but don't want to block you.
Thanks, double checked the region tags to make sure they are conforming to go/code-snippets-style#use-correct-region-tags |
This is a follow up PR for dataplane code snippets for feature store service