Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add labels to all resource creation apis #601

Conversation

morgandu
Copy link
Contributor

@morgandu morgandu commented Aug 10, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #595, <b/191789899> 🦕

  • Add support for labels in resources creation:

    • datasets (create)
      • ImageDataset / TabularDataset / TextDataset / TimeSeriesDataset / VideoDataset
    • tensorboard
      • Tensorboard.create
    • jobs
      • BatchPredictionJob.create
      • CustomJob.__init__
      • HyperparameterTuningJob.__init__
    • models
      • Endpoint.create
      • Model.upload / Model.batch_predict
    • training_jobs (__init__ for training labels, run for model labels)
      • CustomTrainingJob / CustomContainerTrainingJob / CustomPythonPackageTrainingJob
      • AutoMLTabularTrainingJob / AutoMLForecastingTrainingJob / AutoMLImageTrainingJob / AutoMLVideoTrainingJob / AutoMLTextTrainingJob
  • Modify pipeline_jobs.py and utils.py for validate_labels reusability

  • Add / modify unit tests to verify:

    • standard resource creation with / without labels
    • training pipeline resource creation
      • when model labels is not provided
      • when base model labels is provided

@morgandu morgandu requested a review from a team as a code owner August 10, 2021 17:09
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Aug 10, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2021
@morgandu morgandu force-pushed the mor--support-labels-on-all-resource-creation-apis branch from ea0106a to cb6f18e Compare August 10, 2021 17:18
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work!

@sasha-gitg sasha-gitg added the automerge Merge the pull request once unit tests and other checks pass. label Aug 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4e7666a into googleapis:master Aug 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 11, 2021
@morgandu morgandu deleted the mor--support-labels-on-all-resource-creation-apis branch August 11, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add labels on CustomTrainingJob class
3 participants