Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add labels on CustomTrainingJob class #595

Closed
DimasAdinugroho opened this issue Aug 6, 2021 · 0 comments · Fixed by #601
Closed

add labels on CustomTrainingJob class #595

DimasAdinugroho opened this issue Aug 6, 2021 · 0 comments · Fixed by #601
Assignees
@morgandu
Labels
api: aiplatform Issues related to the AI Platform API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@DimasAdinugroho
Copy link

I don't see how to add labels on CustomTrainingJob and CustomPythonPackageTrainingJob class, but there are labels parameter when using REST API. How to add the labels?
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Aug 6, 2021
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Aug 7, 2021
@morgandu morgandu added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Aug 10, 2021
@morgandu morgandu mentioned this issue Aug 10, 2021
Merged
3 tasks
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 11, 2021
@morgandu
Feat: add labels to all resource creation apis (#601)
4e7666a 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #595, <b/191789899> 🦕

- Add support for labels in resources creation: 
    - datasets (`create`)
        - ImageDataset / TabularDataset / TextDataset / TimeSeriesDataset / VideoDataset
    - tensorboard 
        - `Tensorboard.create`
    - jobs
        - `BatchPredictionJob.create`
        - `CustomJob.__init__`
        - `HyperparameterTuningJob.__init__`
    - models
        - `Endpoint.create`
        - `Model.upload` / `Model.batch_predict`
    - training_jobs (`__init__` for training labels, `run` for model labels)
        - CustomTrainingJob / CustomContainerTrainingJob / CustomPythonPackageTrainingJob 
        - AutoMLTabularTrainingJob / AutoMLForecastingTrainingJob / AutoMLImageTrainingJob / AutoMLVideoTrainingJob / AutoMLTextTrainingJob 

- Modify `pipeline_jobs.py` and `utils.py` for `validate_labels` reusability
- Add / modify unit tests to verify:
    - standard resource creation with / without labels
    - training pipeline resource creation
        - when model labels is not provided
        - when base model labels is provided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morgandu morgandu

Labels
api: aiplatform Issues related to the AI Platform API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: add labels to all resource creation apis morgandu/python-aiplatform
3 participants
@DimasAdinugroho @morgandu @yoshi-automation