Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-add py sessions to noxfile #22

Merged
merged 7 commits into from
Oct 19, 2020
Merged

fix: re-add py sessions to noxfile #22

merged 7 commits into from
Oct 19, 2020

Conversation

busunkim96
Copy link
Contributor

It looks like these disappeared in a manual generation.

Unfortunately that likely means nox hasn't been running most of the sessions, so this PR may fail on existing code.

@busunkim96 busunkim96 requested a review from a team as a code owner October 5, 2020 23:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 5, 2020
@google-cla
Copy link

google-cla bot commented Oct 19, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 19, 2020
@google-cla
Copy link

google-cla bot commented Oct 19, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

busunkim96
busunkim96 commented Oct 19, 2020
View reviewed changes
google/cloud/aiplatform/__init__.py
@@ -15,6 +15,4 @@
# limitations under the License.
#

from google.cloud.aiplatform import gapic
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was raising an "imported but unused error". Let me know if I should re-add it.

noxfile.py
@@ -156,7 +156,7 @@ def docs(session):
shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
session.run(
"sphinx-build",
"-W", # warnings as errors
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remove this because there were warnings in the docs build. The session will only fail on sphinx errors.

@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. cla: no labels Oct 19, 2020
@google-cla
Copy link

google-cla bot commented Oct 19, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 19, 2020
@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. cla: no labels Oct 19, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2020
@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 19, 2020
@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. cla: no labels Oct 19, 2020
@google-cla
Copy link

google-cla bot commented Oct 19, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@busunkim96
Copy link
Contributor Author

Not sure why cla-bot is unhappy, but all commits were made by Googlers with valid CLAs.

@busunkim96
Copy link
Contributor Author

@dizcology Please review the comments and merge if you're OK with the additional changes I made

@dizcology dizcology merged commit 3c713d5 into master Oct 19, 2020
busunkim96 added a commit that referenced this pull request Oct 20, 2020
@busunkim96 @dizcology @vinnysenthil
chore: update dev with changes to master (#33)
e43bee1 
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (#20)

* name space google.cloud.aiplatform.gapic

* Init Disclaimer (#28)

* clean up docstrings that are not rendered properly in reference doc (#24)

Co-authored-by: Vinny Senthil <[email protected]>

* fix: re-add py sessions to noxfile (#22)

* fix: re-add py sessions to noxfile

Co-authored-by: Vinny Senthil <[email protected]>

Co-authored-by: Yu-Han Liu <[email protected]>
Co-authored-by: Vinny Senthil <[email protected]>
dizcology added a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
@busunkim96 @dizcology @vinnysenthil
chore: update dev with changes to master (googleapis#33)
6958de8 
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (googleapis#20)

* name space google.cloud.aiplatform.gapic

* Init Disclaimer (googleapis#28)

* clean up docstrings that are not rendered properly in reference doc (googleapis#24)

Co-authored-by: Vinny Senthil <[email protected]>

* fix: re-add py sessions to noxfile (googleapis#22)

* fix: re-add py sessions to noxfile

Co-authored-by: Vinny Senthil <[email protected]>

Co-authored-by: Yu-Han Liu <[email protected]>
Co-authored-by: Vinny Senthil <[email protected]>
dizcology added a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
@busunkim96 @dizcology @vinnysenthil
chore: update dev with changes to master (googleapis#33)
83b2b9a 
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (googleapis#20)

* name space google.cloud.aiplatform.gapic

* Init Disclaimer (googleapis#28)

* clean up docstrings that are not rendered properly in reference doc (googleapis#24)

Co-authored-by: Vinny Senthil <[email protected]>

* fix: re-add py sessions to noxfile (googleapis#22)

* fix: re-add py sessions to noxfile

Co-authored-by: Vinny Senthil <[email protected]>

Co-authored-by: Yu-Han Liu <[email protected]>
Co-authored-by: Vinny Senthil <[email protected]>
@vinnysenthil vinnysenthil deleted the fix-noxfile branch December 3, 2021 08:41
@parthea parthea mentioned this pull request Aug 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnysenthil vinnysenthil vinnysenthil approved these changes

@dizcology dizcology dizcology approved these changes

@tmatsuo tmatsuo tmatsuo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@busunkim96 @googlebot @tmatsuo @dizcology @vinnysenthil