Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change default for create_request_timeout arg to None #1175

Merged
merged 3 commits into from
Apr 20, 2022
Merged

fix: change default for create_request_timeout arg to None #1175

merged 3 commits into from
Apr 20, 2022

Conversation

sararob
Copy link
Contributor

@sararob sararob commented Apr 20, 2022

Change default value for create_request_timeout from False to None and add test for when create_request_timeout isn't explicitly set.

Fixes b/229868042 🦕

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 20, 2022
@sararob sararob requested a review from sasha-gitg April 20, 2022 18:08
@sasha-gitg sasha-gitg added the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 47791f7 into googleapis:main Apr 20, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2022
@release-please release-please bot mentioned this pull request Apr 20, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sararob @sasha-gitg