test: verify json_name is respected #270
Conversation
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 22 +2
Lines 862 961 +99
Branches 149 170 +21
=========================================
+ Hits 862 961 +99
Continue to review full report at Codecov.
|
Fields can customize their json name representation. Add a test to verify that this customization is respected by both Python and C++ runtimes. Boost protobuf requirement to gain required upstream bugfix.
software-dov
force-pushed
the
json-name
branch
from
c2d461a to
ff33235
Compare
| # | ||
| # e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev", | ||
| # Then this file should have foo==1.14.0 | ||
| protobuf==3.15.6 |
There was a problem hiding this comment.
This should have updated to the minimum supported version (so that we continue to support it even when future versions are released).
| platforms="Posix; MacOS X", | ||
| include_package_data=True, | ||
| install_requires=("protobuf >= 3.12.0",), | ||
| install_requires=("protobuf >= 3.19.0",), |
There was a problem hiding this comment.
This should not have been included in a patch release. It's causing problems over in the conda ecosystem, where the version of libprotobuf is a bit slower to update as it require recompilation of many many packages. Currently the latest grcp-cpp package is compiled with libprotobuf==3.18.1.
There was a problem hiding this comment.
Update: literally today is when they are rolling out changes to the build environment to support protobuf 3.19 conda-forge/grpc-cpp-feedstock#124
There was a problem hiding this comment.
For future reference, this is the where pin for conda was updated: conda-forge/conda-forge-pinning-feedstock#2049
I recommend we don't update minimum protobuf beyond this in future
There was a problem hiding this comment.
Do we need to add conda tests to verify that installation is possible?
4 participants
Fields can customize their json name representation.
Add a test to verify that this customization is respected by both
Python and C++ runtimes.
Boost protobuf requirement to gain required upstream bugfix.