-
Notifications
You must be signed in to change notification settings - Fork 429
Add to/from json methods to Credentials classes #385
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
oauth2client/client.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
oauth2client/client.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
CLAs look good, thanks! |
|
Thanks for the review, addressed most of the comments and pushed a new commit. |
oauth2client/service_account.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
oauth2client/client.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
This LGTM but would like to give @nathanielmanistaatgoogle a chance to make a pass. |
|
"Resovles" in your commit message is a typo and should be "Resolves", right? |
|
Yeah |
|
Thanks for catching the typo. Fixed. |
|
(Will have other comments later; still working through the content of this change.) |
oauth2client/client.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
oauth2client/service_account.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Addressed feedback. PTAL @nathanielmanistaatgoogle |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Aside from what we're discussing about the TODO comment I'm happy with the content of this change. Please squash commits - a code review is just a code review; there's no need for this change to be more than one piece of project history (two after GitHub does its thing). |
This adds to_json and from_json methods to GoogleCredentials and _ServiceAccountCredentials classes. This allows them to be serialized by multistore_file. Resolves: googleapis#384
|
Added the TODO and squashed. Thanks for the review! |
|
Looks good; only waiting for tests to repass. |
Add to/from json methods to Credentials classes.
This adds to_json and from_json methods to GoogleCredentials
and _ServiceAccountCredentials classes. This allows them to
be serialized by multistore_file.
Resovles: #384