Skip to content
This repository was archived by the owner on Jan 18, 2025. It is now read-only.

Adding dictionary storage for #319. #380

Merged
nathanielmanistaatgoogle merged 1 commit into from
Jan 11, 2016
Merged

Adding dictionary storage for #319. #380

nathanielmanistaatgoogle merged 1 commit into from
Jan 11, 2016

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Jan 6, 2016

DictionaryStorage implements an optionally-locked storage over a dictionary-like object.

After this is merged, there will be one more PR to replace FlaskSessionStorage and DjangoSessionStorage with this class. ;)

@theacodes theacodes force-pushed the add-dictionary-storage branch from 93d90e3 to d7c2803 Compare January 6, 2016 18:57
dhermes
dhermes reviewed Jan 6, 2016
View reviewed changes
oauth2client/contrib/dictionary_storage.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes theacodes force-pushed the add-dictionary-storage branch from d7c2803 to af6e7ac Compare January 6, 2016 19:49
@theacodes
Copy link
Contributor Author

theacodes commented Jan 6, 2016

AttributeError: 'DictionaryStorageTests' object has no attribute 'assertIsNone'

I hate python 2.6 so much.

@theacodes theacodes force-pushed the add-dictionary-storage branch from af6e7ac to 402c39e Compare January 6, 2016 19:53
@theacodes
Copy link
Contributor Author

theacodes commented Jan 6, 2016

Coverage increased (+0.06%) to 94.508%

In your face, coveralls.

@theacodes
Copy link
Contributor Author

theacodes commented Jan 6, 2016

@dhermes I believe I addressed everything.

@dhermes
Copy link
Contributor

dhermes commented Jan 6, 2016

You can avoid the py2.6 pain by using unittest2. It's already a test-dep.

@theacodes theacodes force-pushed the add-dictionary-storage branch from 402c39e to 1817791 Compare January 6, 2016 20:04
@theacodes
Copy link
Contributor Author

theacodes commented Jan 6, 2016

You can avoid the py2.6 pain by using unittest2. It's already a test-dep.

Done.

dhermes
dhermes reviewed Jan 6, 2016
View reviewed changes
tests/contrib/test_dictionary_storage.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes theacodes force-pushed the add-dictionary-storage branch 2 times, most recently from 2a43643 to 0af1237 Compare January 6, 2016 20:20
dhermes
dhermes reviewed Jan 6, 2016
View reviewed changes
tests/contrib/test_dictionary_storage.py

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Jan 6, 2016

LGTM. Will wait on @nathanielmanistaatgoogle

@theacodes theacodes force-pushed the add-dictionary-storage branch from 0af1237 to c408aed Compare January 6, 2016 20:45
nathanielmanistaatgoogle
nathanielmanistaatgoogle reviewed Jan 8, 2016
View reviewed changes
tests/contrib/test_dictionary_storage.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes theacodes force-pushed the add-dictionary-storage branch from c408aed to 07b35d7 Compare January 11, 2016 17:31
Adding dictionary storage for googleapis#319.
782db0b 
DictionaryStorage implements an optionally-locked storage over a dictionary-like object.
@theacodes theacodes force-pushed the add-dictionary-storage branch from 07b35d7 to 782db0b Compare January 11, 2016 17:33
nathanielmanistaatgoogle added a commit that referenced this pull request Jan 11, 2016
@nathanielmanistaatgoogle
Merge pull request #380 from jonparrott/add-dictionary-storage
6e47281 
Added dictionary storage for #319.
@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit 6e47281 into googleapis:master Jan 11, 2016
@theacodes theacodes deleted the add-dictionary-storage branch January 11, 2016 18:09
@theacodes
Copy link
Contributor Author

theacodes commented Jan 11, 2016

Thanks! :)

@dhermes dhermes mentioned this pull request Jan 29, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theacodes @dhermes @nathanielmanistaatgoogle @googlebot