Move non-core modules to contrib.

[theacodes]

Fixes #352

[theacodes]

Most of this is just moving code around, however, I did have to surgically remove the multstore tests from the file tests.

[dhermes]

@jonparrott Please please please please please stop doing "just a little extra" in a PR.

Do the surgery first. Then do this renaming.

[dhermes]

Such ocean. Much boil.

[theacodes]

I'm sorry, I know these take lots of time to review. The options were:

• Make tests.test_file depend on a contrib module, and it being the only core test or module that does.
• Move the tests into tests.contrib.test_multistore_file, therefore making clean separation between core and contrib.

I really don't like to leave the codebase in a intermediate state such as "moved to contrib, but core still depends on it".

This is the last boil the ocean commit. Promise. I am planning to follow through with renaming some of the older storage classes, but I'll do each of those as a separate commit.

[dhermes]

Ha, last one! Bold statement.

Why is splitting the tests apart not doable as a pre-amble to this commit? (UPDATE: i.e. Why does that leave things in a broken state?)

[theacodes]

Why is splitting the tests apart not doable as a pre-amble to this commit?

You mean split the tests first, then do this? I mean, I could. If you want.

[dhermes]

You should, I do.

This PR should just be a bunch of file renames.

[theacodes]

Will do. Would you prefer two PRs or two commits?

(This PR will need to change imports and a few mock statements, so it won't be as simple as just file renames)

[dhermes]

Two PRs.

[dhermes]

Yes I realize it's not as simple as file renames, but the other changes (like ignoring new dirs on tox.ini) are simple enough to understand.

[theacodes]

@dhermes this has been rebased and is ready for review.

[dhermes]

Finished review. Looks mostly good. Ping me once done with changes (I asked for at least one, but maybe only one, if that's the case I apologize for making changes plural).

[dhermes]

LGTM

[dhermes]

@jonparrott Did you mean to erase the appengine module in this PR?

[dhermes]

NVM I am stupid

[dhermes]

======================================================================
ERROR: Failure: ImportError (No module named dev_appserver)   
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../oauth2client/.tox/cover/local/lib/python2.7/site-packages/nose/loader.py", line 418, in loadTestsFromName
    addr.filename, addr.module)
  File ".../oauth2client/.tox/cover/local/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File ".../oauth2client/.tox/cover/local/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File ".../oauth2client/tests/contrib/test_appengine.py", line 32, in <module>
    import dev_appserver
ImportError: No module named dev_appserver
-------------------- >> begin captured logging << --------------------
py.warnings: WARNING: .../oauth2client/.tox/cover/local/lib/python2.7/site-packages/django/db/models/fields/subclassing.py:22: RemovedInDjango110Warning: SubfieldBase has been 
deprecated. Use Field.from_db_value instead.
  RemovedInDjango110Warning)

[dhermes]

OK maybe I'm not crazy since

nosetests --with-coverage --cover-package=oauth2client --cover-package=tests \
--cover-erase --cover-tests --cover-branches --ignore-files=contrib/test_appengine\.py

should not result in an import error in

.../oauth2client/tests/contrib/test_appengine.py

[theacodes]

Ugh, app engine. Created a new PR #363.

[dhermes]

Thanks. AFAICT the issue was actually the slash that we discussed.