Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat: check status of long running operation by its name #435

Merged
merged 1 commit into from
May 6, 2020

Conversation

alexander-fenster
Copy link
Contributor

For each client method returning a long running operation, a separate method to check its status is added.

Added methods: checkAnnotateVideoProgress.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2020
@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label May 6, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

For each client method returning a long running operation, a separate method to check its status is added.

Added methods: `checkAnnotateVideoProgress`.
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #435 into master will increase coverage by 0.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   94.55%   95.07%   +0.51%     
==========================================
  Files          12       12              
  Lines        2702     2882     +180     
  Branches      200      210      +10     
==========================================
+ Hits         2555     2740     +185     
+ Misses        142      137       -5     
  Partials        5        5              
Impacted Files Coverage Δ
src/v1/video_intelligence_service_client.ts 94.84% <100.00%> (+0.63%) ⬆️
src/v1beta2/video_intelligence_service_client.ts 94.84% <100.00%> (+0.63%) ⬆️
src/v1p1beta1/video_intelligence_service_client.ts 96.90% <100.00%> (+0.47%) ⬆️
src/v1p2beta1/video_intelligence_service_client.ts 94.84% <100.00%> (+0.63%) ⬆️
src/v1p3beta1/video_intelligence_service_client.ts 94.84% <100.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 604fdd6...5d392b9. Read the comment docs.

@alexander-fenster alexander-fenster merged commit be4793e into master May 6, 2020
@alexander-fenster alexander-fenster deleted the get-lro-status branch May 6, 2020 07:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants