Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

feat!: v3 is now the default API surface #355

Merged
bcoe merged 14 commits into from
Oct 28, 2019
Merged

feat!: v3 is now the default API surface #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5e96613
feat: adding v3 module in TypeScript
alexander-fenster Oct 24, 2019
bea6364
tsignore
alexander-fenster Oct 24, 2019
310cf60
gts fix
alexander-fenster Oct 24, 2019
1b3400c
feat!: v3 is now the default API surface
Oct 25, 2019
3420b75
chore: fix up license headers
Oct 25, 2019
2b69137
Add Translation v3 samples
nnegrey Oct 25, 2019
7129b30
Fix License headers
nnegrey Oct 25, 2019
59f8077
Test License headers
nnegrey Oct 25, 2019
a0e9592
Linter
nnegrey Oct 25, 2019
5c144d3
Update quickstart.js
nnegrey Oct 28, 2019
bbe3ae1
chore: slight formatting fix
Oct 28, 2019
d9a1363
Update v2 samples to use async functions inside region tag code
nnegrey Oct 28, 2019
3f06c9d
Remove unncessary async on outer functions
nnegrey Oct 28, 2019
cc7fcf0
chore: address linting issue
Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .bots/header-checker-lint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"ignoreFiles": ["protos/*"]
Copy link
Contributor

@JustinBeckwith JustinBeckwith Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure about that? Instead, I'd rather we make the change in the underlying generator/protos if needed. If we don't want to block on that, please leave a TODO with a reference to a tracking bug so we don't lose this.

Copy link
Author

@bcoe bcoe Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustinBeckwith created a TODO on this repo, #356

@alexander-fenster could you perhaps create a corresponding tracking issue, for adding license headers, and reference #356.

}
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"lint": "npm run check && eslint '**/*.js'",
"samples-test": "cd samples/ && npm link ../ && npm test && cd ../",
"system-test": "mocha build/system-test --timeout 600000",
"test": "nyc mocha build/test",
"test": "c8 mocha build/test",
"check": "gts check",
"clean": "gts clean",
"compile": "tsc -p . && npm run copy-js",
Expand Down Expand Up @@ -62,6 +62,7 @@
"@types/node": "^10.5.7",
"@types/proxyquire": "^1.3.28",
"@types/request": "^2.47.1",
"c8": "^6.0.0",
"codecov": "^3.0.2",
"eslint": "^6.0.0",
"eslint-config-prettier": "^6.0.0",
Expand All @@ -73,7 +74,6 @@
"jsdoc-fresh": "^1.0.1",
"linkinator": "^1.5.0",
"mocha": "^6.1.4",
"nyc": "^14.0.0",
"power-assert": "^1.6.0",
"prettier": "^1.13.5",
"proxyquire": "^2.0.1",
Expand Down
Loading