[CHANGE ME] Re-generated to pick up changes in the API or client library generator. #350

yoshi-automation · 2020-02-06T12:39:05Z

This PR was generated using Autosynth. 🌈

Commits in this repo since last synth:
ed9d4ae test: modernize mocha config (#345)
1b70d9b chore: skip img.shields.io in docs test
b0c79f5 chore(deps): update dependency @types/mocha to v7
d591c6d chore: release 1.7.2 (#341)

Log from Synthtool

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Cloning googleapis.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:9b805f503bb59459845d4f84f02afdd70f41ed532907f775ca8119caef1a478f
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/cloud/tasks/v2beta2.
synthtool > Generated code into /tmpfs/tmp/tmp0lws4jmd.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:9b805f503bb59459845d4f84f02afdd70f41ed532907f775ca8119caef1a478f
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/cloud/tasks/v2beta3.
synthtool > Generated code into /tmpfs/tmp/tmp4paow008.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:9b805f503bb59459845d4f84f02afdd70f41ed532907f775ca8119caef1a478f
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/cloud/tasks/v2.
synthtool > Generated code into /tmpfs/tmp/tmpdd7f4efh.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/release-please.yml
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node12/common.cfg
.kokoro/continuous/node12/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node12/common.cfg
.kokoro/presubmit/node12/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/docs.cfg
.kokoro/release/docs.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
codecov.yaml
renovate.json
samples/README.md
synthtool > No replacements made in **/doc/google/protobuf/doc_timestamp.js for pattern https:\/\/cloud\.google\.com[\s\*]*http:\/\/(.*)[\s\*]*\), maybe replacement is not longer needed?
synthtool > No replacements made in **/doc/google/protobuf/doc_timestamp.js for pattern toISOString\], maybe replacement is not longer needed?
synthtool > Replaced '"initial_rpc_timeout_millis": 60000' in src/v2/cloud_tasks_client_config.json.
synthtool > Replaced '"initial_rpc_timeout_millis": 60000' in src/v2beta2/cloud_tasks_client_config.json.
synthtool > Replaced '"initial_rpc_timeout_millis": 60000' in src/v2beta3/cloud_tasks_client_config.json.
synthtool > Replaced '"max_rpc_timeout_millis": 60000' in src/v2/cloud_tasks_client_config.json.
synthtool > Replaced '"max_rpc_timeout_millis": 60000' in src/v2beta2/cloud_tasks_client_config.json.
synthtool > Replaced '"max_rpc_timeout_millis": 60000' in src/v2beta3/cloud_tasks_client_config.json.
npm WARN npm npm does not support Node.js v12.14.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> [email protected] postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall


> @google-cloud/[email protected] prepare /tmpfs/src/git/autosynth/working_repo
> npm run compile

npm WARN npm npm does not support Node.js v12.14.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/[email protected] compile /tmpfs/src/git/autosynth/working_repo
> tsc -p . && cp -r protos build/

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/watchpack/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 940 packages from 944 contributors and audited 6789 packages in 24.883s
found 0 vulnerabilities

npm WARN npm npm does not support Node.js v12.14.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/[email protected] fix /tmpfs/src/git/autosynth/working_repo
> gts fix

installing semver@^5.5.0
installing minimist@^1.2.0
installing uglify-js@^3.3.25
installing espree@^3.5.4
installing escodegen@^1.9.1
synthtool > Wrote metadata to synth.metadata.

…ary generator.

codecov · 2020-02-06T12:42:50Z

Codecov Report

Merging #350 into master will not change coverage.
The diff coverage is 75%.

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files           7        7           
  Lines        6767     6767           
  Branches      229      229           
=======================================
  Hits         6252     6252           
  Misses        512      512           
  Partials        3        3

Impacted Files	Coverage Δ
src/v2beta3/cloud_tasks_client.ts	`92.04% <75%> (ø)`	⬆️
src/v2beta2/cloud_tasks_client.ts	`92.73% <75%> (ø)`	⬆️
src/v2/cloud_tasks_client.ts	`92.02% <75%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9d4ae...2f0e46a. Read the comment docs.

JustinBeckwith · 2020-02-06T15:37:00Z

src/v2/cloud_tasks_client.ts

@@ -2052,6 +1992,66 @@ export class CloudTasksClient {
    return this._pathTemplates.taskPathTemplate.match(taskName).task;
  }

+  /**


@alexander-fenster @xiaozhenliu-gg5 if I'm reading this right, it looks like the order of the generated methods are bouncing a round a bit. They don't seem to be in alphabetical order, so I'm not sure if this is intended or not. Do we have jitter here?

We had a sequence of logic changes here trying to make some weird APIs work. We do sort them, but there appears to be a bug there :)

augmentedService.pathTemplates = Object.values(uniqueResources).sort();

here sort() is applied to objects and the results are quite random, as you see.

Let me fix this and I'll regen the APIs today with a set of mass PRs. I'll repo reject the open ones.

googleapis/gapic-generator-typescript#231

JustinBeckwith · 2020-02-06T15:37:28Z

src/v2/cloud_tasks_proto_list.json

@@ -1,6 +1,6 @@
 [
-  "../../protos/google/cloud/tasks/v2/target.proto",
+  "../../protos/google/cloud/tasks/v2/cloudtasks.proto",


this at least looks to be sorted now

[CHANGE ME] Re-generated to pick up changes in the API or client libr…

2f0e46a

…ary generator.

yoshi-automation force-pushed the autosynth branch from 3b32d17 to 2f0e46a Compare February 6, 2020 12:39

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2020

JustinBeckwith suggested changes Feb 6, 2020

View reviewed changes

alexander-fenster mentioned this pull request Feb 6, 2020

fix: sort path templates, ignore useless templates googleapis/gapic-generator-typescript#231

Merged

alexander-fenster closed this Feb 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CHANGE ME] Re-generated to pick up changes in the API or client library generator. #350

[CHANGE ME] Re-generated to pick up changes in the API or client library generator. #350

yoshi-automation commented Feb 6, 2020

codecov bot commented Feb 6, 2020 •

edited

Loading

JustinBeckwith Feb 6, 2020

alexander-fenster Feb 6, 2020

alexander-fenster Feb 6, 2020

JustinBeckwith Feb 6, 2020

alexander-fenster Feb 6, 2020

[CHANGE ME] Re-generated to pick up changes in the API or client library generator. #350

[CHANGE ME] Re-generated to pick up changes in the API or client library generator. #350

Conversation

yoshi-automation commented Feb 6, 2020

codecov bot commented Feb 6, 2020 • edited Loading

Codecov Report

JustinBeckwith Feb 6, 2020

Choose a reason for hiding this comment

alexander-fenster Feb 6, 2020

Choose a reason for hiding this comment

alexander-fenster Feb 6, 2020

Choose a reason for hiding this comment

JustinBeckwith Feb 6, 2020

Choose a reason for hiding this comment

alexander-fenster Feb 6, 2020

Choose a reason for hiding this comment

codecov bot commented Feb 6, 2020 •

edited

Loading