feat: add file.isPublic() function

[AVaksman]

Fixes #683

• Tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

[codecov]

Codecov Report

Merging #708 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
+ Coverage   96.77%   96.79%   +0.01%     
==========================================
  Files           9        9              
  Lines        1149     1155       +6     
  Branches      294      295       +1     
==========================================
+ Hits         1112     1118       +6     
  Misses          9        9              
  Partials       28       28

Impacted Files	Coverage Δ
src/file.ts	98.12% <100%> (+0.02%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f8a74...06474dc. Read the comment docs.

[jkwlui]

gaxios is not in package.json explicitly. If we're using gaxios to make requests, then we should add it to package.json under dependencies

[AVaksman]

gaxios is not in package.json explicitly. If we're using gaxios to make requests, then we should add it to package.json under dependencies

Done, thank you

[stephenplusplus]

I think we need to encode the name:

url: `http://${this.bucket.name}.storage.googleapis.com/${encodeURIComponent(this.name)}`,

[AVaksman]

sure, done

It only matters in the case where file.name property is changed on an already existing file object, which would render all other file properties' values incorrect in respect to the new file.name.
Shouldn't the file.name property be made readonly?

[stephenplusplus]

It only matters in the case where file.name property is changed

Do you mean the name property is already encoded? I didn't see that in the code.

Shouldn't the file.name property be made readonly?

I suppose. name wasn't intended to be a public property at all.

[stephenplusplus]

Sorry I didn't think of this sooner.

[stephenplusplus]

We should explain how we are doing this. It is possible the server has a hiccup and returns an error code, even though the file is public.

[AVaksman]

Done!
Thanks

[frankyn]

Thanks @AVaksman for putting this together. Apologies for the delay in my review, LGTM.

[AVaksman]

Thanks @AVaksman for putting this together. Apologies for the delay in my review, LGTM.

Thanks.