fix(bucket): Only disable resumable uploads for bucket.upload (fixes #1133)

[rhodgkins]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #1133

I've added a test case for this by stubbing fs.stat - I hope that's ok!

[JustinBeckwith]

@jkwlui any movement on this PR?

[jkwlui]

@stephenplusplus let's move forward with this PR, if everything looks okay to you.

[stephenplusplus]

Thanks @rhodgkins! Great work on the tests 👍

[stephenplusplus]

@rhodgkins would you mind updating the PR against our latest master? You might also have the option on this page to give us write access to your fork, which would allow us to make the change. (I'm not sure that's a thing, but I recall seeing the option somewhere before)

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[codecov]

Codecov Report

Merging #1135 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1135   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          12       12           
  Lines       11437    11440    +3     
  Branches      524      589   +65     
=======================================
+ Hits        11345    11348    +3     
  Misses         92       92           

Impacted Files	Coverage Δ
src/bucket.ts	99.58% <100.00%> (+<0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a92b7bb...0e57621. Read the comment docs.

[rhodgkins]

@stephenplusplus done (sorry about the noise, I tired to update via GitHub UI and it wasn't the email I signed the CLA with, so I rebased and force pushed...!)

And I know the option you mean re allowing maintainers to edit, but I can't find the option (I recall it being there when I created the PR).
Any ideas as to why the linter is now failing?

[stephenplusplus]

The linter had a small issue with how fs was being imported, but when I looked closer at the tests, I thought I would do a small refactor of the mocking logic to sync with how we're currently doing it. Here's a diff you can apply, which should 🤞 get us green lights from CI.

Here's a gist: https://gist.github.com/stephenplusplus/3dd358c7f98aeca2b55a7355750a3e5f

And to quickly apply it:

$ curl https://gist.githubusercontent.com/stephenplusplus/3dd358c7f98aeca2b55a7355750a3e5f/raw/05525a9344c6151b1e7d9b362980dceb658f58f3/storage-1135.diff | git apply 
`

[rhodgkins]

@stephenplusplus patch applied - also rebased from master