-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baseurl is not quite right when using STORAGE_EMULATOR_HOST #1314
Labels
api: storage
Issues related to the googleapis/nodejs-storage API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
product-auto-label
bot
added
the
api: storage
Issues related to the googleapis/nodejs-storage API.
label
Oct 16, 2020
cc @jkwlui @frankyn this is the origin discussion: #1161 (comment) |
Thanks for reporting @jpambrun! |
shaffeeullah
added
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
and removed
triage me
I really want to be triaged.
labels
Oct 20, 2020
yoshi-automation
added
🚨
This issue needs some love.
and removed
🚨
This issue needs some love.
labels
Jan 18, 2021
gcf-owl-bot bot
added a commit
that referenced
this issue
Dec 30, 2021
Source-Link: googleapis/synthtool@dd6754c Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:f092066de33d4a2a13ab13c8fa9dcb4f6b96fa1fb7d391bf19cd0c4921d997c0
This was referenced Sep 20, 2022
mgabeler-lee-6rs
added a commit
to mgabeler-lee-6rs/nodejs-storage
that referenced
this issue
Sep 20, 2022
ddelgrosso1
pushed a commit
that referenced
this issue
Oct 18, 2022
* fix: correct STORAGE_EMULATOR_HOST handling (#2069, #1314) credit to @jpambrun for identifying the fix * fix: normalize baseUrl Co-authored-by: Daniel Bankhead <[email protected]> * fix: adjust URL normalization & tests for consistency Co-authored-by: Daniel Bankhead <[email protected]>
danielbankhead
added a commit
that referenced
this issue
Oct 19, 2022
shaffeeullah
pushed a commit
that referenced
this issue
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/nodejs-storage API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
I think this line should read:
I guess the intend was to have configurable path, not only the host, but it breaks either bucket api or the object api.
Currently, with the default url, we get
while with a
EMULATOR_HOST= https://exmaple.com
we getAs a result, when EMULATOR_HOST is set with
https://exmaple.com
I can create buckets (the url starts with/storage/v1
), but can't upload/download file (url starts with/upload/storage/v1
). If I set EMULATOR_HOST to https://exmaple.com/v1/storage/ I have the inverse problem (can't create bucket, but can upload/download)The text was updated successfully, but these errors were encountered: