Skip to content

Conversation

@yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:5fd9aee1d82a00cebf425c8fa431f5457539562f5867ad9c54370f0ec9a7ccaa
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/spanner/artman_spanner.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/spanner-v1.
synthtool > Running generator for google/spanner/admin/database/artman_spanner_admin_database.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/spanner-admin-database-v1.
synthtool > Running generator for google/spanner/admin/instance/artman_spanner_admin_instance.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/spanner-admin-instance-v1.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node11/common.cfg
.kokoro/continuous/node11/test.cfg
.kokoro/continuous/node6/common.cfg
.kokoro/continuous/node6/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/docs.cfg
.kokoro/continuous/node8/lint.cfg
.kokoro/continuous/node8/samples-test.cfg
.kokoro/continuous/node8/system-test-grpcjs.cfg
.kokoro/continuous/node8/system-test.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node11/common.cfg
.kokoro/presubmit/node11/test.cfg
.kokoro/presubmit/node6/common.cfg
.kokoro/presubmit/node6/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/docs.cfg
.kokoro/presubmit/node8/lint.cfg
.kokoro/presubmit/node8/samples-test.cfg
.kokoro/presubmit/node8/system-test-grpcjs.cfg
.kokoro/presubmit/node8/system-test.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
codecov.yaml
renovate.json
synthtool > Replaced "(const SpannerClient = require\\('\\./spanner_client'\\);)" in src/v1/index.js.
synthtool > Replaced '(module\\.exports\\.SpannerClient = SpannerClient;)' in src/v1/index.js.
synthtool > Replaced '../../package.json' in src/v1/database_admin_client.js.
synthtool > Replaced '../../package.json' in src/v1/instance_admin_client.js.
synthtool > Replaced '../../package.json' in src/v1/spanner_client.js.
synthtool > Replaced 'https:\\/\\/cloud\\.google\\.com[\\s\\*]*http:\\/\\/(.*)[\\s\\*]*\\)' in src/v1/doc/google/protobuf/doc_timestamp.js.
synthtool > Replaced 'toISOString\\]' in src/v1/doc/google/protobuf/doc_timestamp.js.
synthtool > Replaced '`\\[a-z\\]\\(https:\\/\\/cloud\\.google\\.com\\[-a-z0-9\\]\\*\\[a-z0-9\\]\\)\\?`' in src/v1/doc/google/spanner/v1/doc_spanner.js.
synthtool > Replaced '`\\[a-z\\]\\(https:\\/\\/cloud\\.google\\.com\\[-a-z0-9\\]\\*\\[a-z0-9\\]\\)\\?`' in src/v1/doc/google/spanner/admin/instance/v1/doc_spanner_instance_admin.js.
synthtool > Replaced '`\\(\\[a-z\\]\\(https:\\/\\/cloud\\.google\\.com\\[-a-z0-9\\]\\*\\[a-z0-9\\]\\)\\?\\)\\?`' in src/v1/doc/google/spanner/v1/doc_spanner.js.
synthtool > Replaced '`\\(\\[a-z\\]\\(https:\\/\\/cloud\\.google\\.com\\[-a-z0-9\\]\\*\\[a-z0-9\\]\\)\\?\\)\\?`' in src/v1/doc/google/spanner/admin/instance/v1/doc_spanner_instance_admin.js.
npm WARN deprecated [email protected]: no longer maintained

> [email protected] install /tmpfs/src/git/autosynth/working_repo/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library

node-pre-gyp WARN Using needle for node-pre-gyp https download 
[grpc] Success: "/tmpfs/src/git/autosynth/working_repo/node_modules/grpc/src/node/extension_binary/node-v57-linux-x64-glibc/grpc_node.node" is installed via remote

> [email protected] postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall


> @google-cloud/[email protected] prepare /tmpfs/src/git/autosynth/working_repo
> npm run compile


> @google-cloud/[email protected] compile /tmpfs/src/git/autosynth/working_repo
> tsc -p . && cp -r src/v1 build/src && cp -r protos build && cp test/*.js build/test

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 1128 packages from 1343 contributors and audited 6555 packages in 34.435s
found 1 low severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details

> @google-cloud/[email protected] fix /tmpfs/src/git/autosynth/working_repo
> gts fix && eslint --fix '**/*.js'

Configuration file(s) do(es) not support C++: /tmpfs/src/git/autosynth/working_repo/.clang-format
Configuration file(s) do(es) not support C++: /tmpfs/src/git/autosynth/working_repo/.clang-format
Configuration file(s) do(es) not support C++: /tmpfs/src/git/autosynth/working_repo/.clang-format
Configuration file(s) do(es) not support C++: /tmpfs/src/git/autosynth/working_repo/.clang-format
Error: clang-format exited with exit code 1.
    at errorFromExitCode (/tmpfs/src/git/autosynth/working_repo/node_modules/clang-format/index.js:16:10)
    at ChildProcess.<anonymous> (/tmpfs/src/git/autosynth/working_repo/node_modules/clang-format/index.js:121:14)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at maybeClose (internal/child_process.js:927:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google-cloud/[email protected] fix: `gts fix && eslint --fix '**/*.js'`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @google-cloud/[email protected] fix script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2019-02-16T12_21_04_473Z-debug.log
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 16, 2019
@callmehiphop
Copy link
Contributor

@JustinBeckwith @alexander-fenster looks like the latest synths give us some new formatting that our linter disagrees with. Seems like maybe we want to apply our formatting rules against the updated files?

@JustinBeckwith
Copy link
Contributor

Yuuuup. There's a bug in clang:
google/gts#267

Good news: the master branch of ts-style uses prettier instead of clang and doesn't have this problem.

Bad news: it's not released yet, and very, very early.

My recommendation - I would submit a PR that disables gts fix or gts check for now, with a follow up issue to turn it back on later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants