-
Notifications
You must be signed in to change notification settings - Fork 112
feat(spanner): add emulator support for the admin client autogenerated API samples #1994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gcf-merge-on-green
merged 57 commits into
googleapis:main
from
alkatrivedi:admin-emulator-support
Feb 28, 2024
Merged
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
d992e90
feat(spanner): emulator support for admin client apis samples
alkatrivedi 0cda32c
fix: lint errors
alkatrivedi 1da0d06
docs: add comment
alkatrivedi 8a8fcfb
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi 1836197
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi c0ba211
refactor: remove redundant code lines
alkatrivedi ae8c194
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi 6084578
refactor: renamed the helper function for the admin client API calls
alkatrivedi d00e7bd
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi e9e72e1
refactor: remove redundant code lines
alkatrivedi bb79fed
refactor if condition
alkatrivedi 88aa219
refactor comments
alkatrivedi b414ef1
refactor: remove added logs
alkatrivedi 6791652
chore: update helper functions for admin clients
alkatrivedi 070c735
refactor: remove unneeded imports
alkatrivedi 51e3fda
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi cdfff7f
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi 5e98c3f
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi f3ba05a
refactor: documention of get instance/database admin client method
alkatrivedi 70ea49f
test: add the integration test for emulator support
alkatrivedi bec0fce
fix: header-checks
alkatrivedi 7b36a00
fix: error in integration test
alkatrivedi 9160ae0
fix: lint errors
alkatrivedi b2d578d
fix: header-checks
alkatrivedi d070abb
fix: license error
alkatrivedi d265645
fix: header-checks
alkatrivedi 09847ce
fix: presubmit error
alkatrivedi 2b25618
fix: presubmit error
alkatrivedi 3754fae
fix: presubmit error
alkatrivedi 1d5cb85
fix: presubmit errors
alkatrivedi 336f1c9
fix: lint error
alkatrivedi ceb3a9c
Documentation and method names
surbhigarg92 4550b07
refactor integration test
alkatrivedi fbba14a
fix presubmit error
alkatrivedi 1c6104f
fix: lint error
alkatrivedi 5d7cdd6
fix: methods documentation
alkatrivedi b05ec94
refactor: methods name
alkatrivedi e756390
fix: presubmit error
alkatrivedi 1e6cf67
Documentation changes
surbhigarg92 bf1590c
Refactor system tests
surbhigarg92 f122cbc
refactor: integration tests
alkatrivedi c0f4b3a
refactor code
alkatrivedi f5a536f
fix: lint error
alkatrivedi 336c78e
refactor: remove redundant file
alkatrivedi fe119e3
fix: presubmit error
alkatrivedi 65c8967
fix: presubmit error
alkatrivedi e52d926
test: add configrations for testing in local
alkatrivedi 828d6cc
refactor: integration test
alkatrivedi 6b95faa
fix: presubmit error
alkatrivedi 53d7dec
review comments
surbhigarg92 ac04630
review comments
surbhigarg92 db0c65d
Apply suggestions from code review
surbhigarg92 9289cda
review comments
surbhigarg92 4603ebe
review comments
surbhigarg92 cfa7196
review comments
surbhigarg92 cb004f2
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] aedbb14
review comments
surbhigarg92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,3 +13,4 @@ system-test/*key.json | |
| package-lock.json | ||
| __pycache__ | ||
| .idea | ||
| .vscode | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.