Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should pass extra callback arguments back to consumer #361

Merged
merged 2 commits into from
May 22, 2024
Merged

fix: should pass extra callback arguments back to consumer #361

merged 2 commits into from
May 22, 2024

Conversation

alvarowolfx
Copy link
Contributor

@alvarowolfx alvarowolfx requested a review from a team as a code owner May 20, 2024 20:58
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 20, 2024
@alvarowolfx
Copy link
Contributor Author

build is failing due to some issues with compodoc dependencies. Waiting for #362 to fix it

ddelgrosso1
ddelgrosso1 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label May 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 21, 2024
@alvarowolfx alvarowolfx merged commit cc5c48b into googleapis:main May 22, 2024
15 checks passed
@release-please release-please bot mentioned this pull request May 22, 2024
Merged
@alvarowolfx alvarowolfx mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feywind feywind feywind approved these changes

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvarowolfx @feywind @ddelgrosso1